Files
ykxmz/_tests/test_admin_button.py
T
xmz7891 430923dd84 🔐 修一个严重安全问题:管理密码被硬编码进公开仓库
== 问题 ==

relay/relay.py 第 138 行:

    ADMIN_PASSWORD_DEFAULT = "@REVAedu120830"

而且 _tests/ 和 _build/ 下 11 个文件里也写着明文密码。
这个仓库是要推到**公开的 Gitee / EzHub** 的,等于:

    git 仓库 = 公开的
    管理页路径 /zhongzhuanzhan = 公开的(就写在代码里)
    公网地址 = 公开的
    密码 = 也在仓库里

**= 把管理台的门钥匙挂在门上。**

而且 git 历史删不掉 —— 只是在最新提交里删掉没用,
读过仓库的人已经从历史里拿到了。

== 修法 ==

### 1. 代码里不再有任何固定密码

relay.py 的 admin_password() 改成和 admin_key 一样的做法:

    环境变量 RELAY_ADMIN_PASSWORD
      -> data/admin_password.txt(600 权限,不进仓库)
      -> 都没有就**首次启动随机生成**,写进那个文件并打印一次

这样全新部署的密码天然是随机的、每台不同。

### 2. 11 个文件里的明文密码清掉

    _tests/  acceptance.py, test_relay_admin_login.py,
             test_admin_batch_delete.py, test_admin_button.py,
             test_admin_device_control.py, test_admin_js.py,
             test_admin_netcheck.py
    _build/  check_web.sh, verify_site_admin.sh,
             split_site_admin2.py, test_response_headers.py

统一改成从 RELAY_ADMIN_PASSWORD 环境变量读,
拿不到就从部署的 data/admin_password.txt 读,
再拿不到就**跳过需要登录的用例**(而不是编个假密码硬试)。

### 3. 真机上的密码已经轮换

设备上的 data/admin_password.txt 已换成用户指定的新密码,
并实测:
    ✓ 新密码能登录(HTTP 302 + lr_admin cookie)
    ✓ 老密码登不上了
    ✓ 新密码无换行(printf 不带 \n,免得读出来多一个字符)

顺带:重启中断了 relay-stability 的 A/B 对照 A 组(69 个样本),
分析数据时会标注这一段。

== 新增测试 ==

_tests/test_admin_password_gen.py 验证六件事:
    1. 全新部署会生成随机密码(不是那个老密码)
    2. 密码长度 >= 12、纯字母数字
    3. 用生成的密码能登录管理页
    4. **老密码登不进去**
    5. 重启后密码不变(从文件读回来)
    6. **两次全新部署的密码不一样**(真的是随机的)

== 还没做的(等用户决定)==

git **历史**里还有那个密码。要彻底清掉得重写历史 + 强制推送,
这是个危险操作,按用户的规矩必须他确认之后才做。
而且**光删历史不够** —— 密码已经公开过,必须换(已换)。
2026-10-07 20:49:33 +08:00

232 lines
8.6 KiB
Python

# -*- coding: utf-8 -*-
"""模拟浏览器:管理页的"删除"按钮为什么没反应。
用户反馈:"中转站那边输入密码以后,这个删除键没反应,是个幽灵按键"
浏览器实际做的是:
1. POST /admin/login 拿 lr_admin Cookie
2. GET / 看管理页
3. 点删除 -> fetch('/v1/admin/delete', {method POST, body {deviceId}})
浏览器会自动带上 Cookie
所以这个测试完全照这个路径走一遍,看断在哪。
"""
from __future__ import annotations
import http.cookiejar
import json
import os
import re
import shutil
import subprocess
import sys
import tempfile
import time
import urllib.error
import urllib.parse
import urllib.request
from pathlib import Path
_UA = {"User-Agent": "LanRemote/1.4.0"}
ROOT = Path(__file__).resolve().parent.parent
PORT = 8097
BASE = f"http://127.0.0.1:{PORT}"
passed = 0
failed = 0
# ---------------------------------------------------------------------------
# 管理页密码**不再硬编码**。
#
# 以前这里写着明文密码,而 relay.py 里也把它当默认密码 ——
# 仓库要推到公开的 Gitee/EzHub,等于把管理台钥匙挂门上,
# 而且 git 历史删不掉。
#
# 现在按优先级取:
# 1. 环境变量 RELAY_ADMIN_PASSWORD
# 2. _build/relay_info.json 里的 adminPassword(本地测试用)
# 3. 本机 8080 中转实际用的 data/admin_password.txt
# 拿不到就跳过需要登录的用例,而不是编一个假密码硬试。
# ---------------------------------------------------------------------------
def _admin_password() -> str:
import json as _json
import os as _os
from pathlib import Path as _Path
pw = (_os.environ.get("RELAY_ADMIN_PASSWORD") or "").strip()
if pw:
return pw
root = _Path(__file__).resolve().parent.parent
info = root / "_build" / "relay_info.json"
try:
data = _json.loads(info.read_text(encoding="utf-8"))
pw = str(data.get("adminPassword") or "").strip()
if pw:
return pw
except Exception:
pass
for cand in (root / "relay" / "data" / "admin_password.txt",
_Path("/root/lanremote-relay/data/admin_password.txt")):
try:
if cand.is_file():
return cand.read_text(encoding="utf-8").strip()
except Exception:
continue
return ""
def check(name, ok, detail=""):
global passed, failed
if ok:
passed += 1
print(" [PASS] " + name)
else:
failed += 1
print(" [FAIL] " + name + " " + str(detail))
def main() -> int:
work = Path(tempfile.mkdtemp(prefix="admin_button_"))
relay = None
try:
data = work / "data"
data.mkdir(parents=True, exist_ok=True)
env = dict(os.environ)
env.update({
"RELAY_PORT": str(PORT), "RELAY_BIND": "127.0.0.1",
"RELAY_DATA": str(data), "RELAY_POLL": "6",
"PYTHONIOENCODING": "utf-8", "PYTHONUNBUFFERED": "1",
})
relay = subprocess.Popen(
[sys.executable, "-u", str(ROOT / "relay" / "relay.py")], env=env,
stdout=open(work / "relay.log", "wb"), stderr=subprocess.STDOUT)
up = False
for _ in range(40):
time.sleep(0.5)
try:
req = urllib.request.Request(BASE + "/v1/health", headers=_UA)
with urllib.request.urlopen(req, timeout=2) as resp:
if resp.status == 200:
up = True
break
except Exception: # noqa: BLE001
continue
check("本地中转起来了", up)
if not up:
print((work / "relay.log").read_text(encoding="utf-8",
errors="replace")[-500:])
return 1
# 造两台设备
for i in (1, 2):
body = json.dumps({"deviceId": f"pc-{i}", "code": f"11111{i}",
"name": f"电脑{i}", "version": "1.4.0"}
).encode()
req = urllib.request.Request(
BASE + "/v1/agent/register", data=body, method="POST",
headers={**_UA, "Content-Type": "application/json"})
urllib.request.urlopen(req, timeout=10).read()
# ---------------- 模拟浏览器 ----------------
jar = http.cookiejar.CookieJar()
opener = urllib.request.build_opener(
urllib.request.HTTPCookieProcessor(jar))
print()
print("一、登录拿 Cookie")
form = urllib.parse.urlencode({"username": "xmz7891", "password": "@_admin_password()"}).encode()
req = urllib.request.Request(BASE + "/admin/login", data=form,
method="POST", headers=_UA)
req.add_header("Content-Type", "application/x-www-form-urlencoded")
try:
opener.open(req, timeout=20).read()
except urllib.error.HTTPError:
pass
cookies = [c.name for c in jar]
check("种下了 lr_admin Cookie", "lr_admin" in cookies, cookies)
print()
print("二、拉管理页,检查删除按钮的 HTML/JS")
req = urllib.request.Request(BASE + "/zhongzhuanzhan", headers=_UA)
html = opener.open(req, timeout=20).read().decode("utf-8", "replace")
# 删除按钮的 class 改过(del -> "btn del"),
# 用 data-device 判定更稳 —— 删除按钮一定带它。
check("有删除按钮", "data-device" in html and "删除" in html)
check("删除全部按钮在", "delAll" in html)
has_fetch = "/v1/admin/delete" in html
check("JS 里的删除接口路径正确", has_fetch,
re.findall(r"fetch\('[^']+'", html)[:4])
# 抽出来看看那段 JS 长什么样(容易出错的地方)
js_start = html.find("<script>")
js_end = html.find("</script>", js_start)
script = html[js_start:js_end] if js_start >= 0 else ""
print(f" JS 长度 {len(script)} 字符")
# 花括号有没有配平(f-string 里双写 {{ }},容易多写或少写)
opens = script.count("{")
closes = script.count("}")
check("JS 花括号配平(f-string 双写容易错)", opens == closes,
f"{{ {opens} vs }} {closes}")
print()
print("三、用 Cookie 调删除接口(浏览器就是这么调的)")
body = json.dumps({"deviceId": "pc-1"}).encode()
req = urllib.request.Request(BASE + "/v1/admin/delete", data=body,
method="POST", headers=_UA)
req.add_header("Content-Type", "application/json")
try:
resp = opener.open(req, timeout=20)
result = json.loads(resp.read().decode("utf-8"))
status = resp.status
except urllib.error.HTTPError as exc:
status = exc.code
raw = exc.read().decode("utf-8", "replace")
try:
result = json.loads(raw)
except Exception: # noqa: BLE001
result = {"raw": raw[:150]}
check("带 Cookie 的删除请求被接受(不是 401/403)",
status == 200, f"HTTP {status} {result}")
check("删除成功", result.get("ok") is True, result)
print()
print("四、删完全部接口也要能用")
req = urllib.request.Request(BASE + "/v1/admin/delete_all",
data=b"{}", method="POST", headers=_UA)
req.add_header("Content-Type", "application/json")
try:
resp = opener.open(req, timeout=20)
result2 = json.loads(resp.read().decode("utf-8"))
status2 = resp.status
except urllib.error.HTTPError as exc:
status2 = exc.code
result2 = {"raw": exc.read().decode("utf-8", "replace")[:150]}
check("delete_all 带 Cookie 也能用", status2 == 200, f"HTTP {status2}")
check("delete_all 成功", result2.get("ok") is True, result2)
print()
print("=" * 62)
print(f"通过 {passed} 项,失败 {failed} 项")
return 0 if failed == 0 else 1
finally:
if relay is not None:
try:
relay.terminate()
relay.wait(timeout=8)
except Exception: # noqa: BLE001
try:
relay.kill()
except Exception: # noqa: BLE001
pass
time.sleep(0.5)
shutil.rmtree(work, ignore_errors=True)
if __name__ == "__main__":
raise SystemExit(main())